ferruzzi commented on code in PR #62616:
URL: https://github.com/apache/airflow/pull/62616#discussion_r2908422049
##########
airflow-core/src/airflow/executors/workloads/callback.py:
##########
@@ -90,7 +90,7 @@ def make(
name=dag_run.dag_model.bundle_name,
version=dag_run.bundle_version,
)
- fname = f"executor_callbacks/{callback.id}" # TODO: better log file
template
+ fname =
f"executor_callbacks/{dag_run.dag_id}/{dag_run.run_id}/{callback.id}"
Review Comment:
We use `log_path=f"{log_path}.trigger.{self.job.id}.log",` in the
`triggerer_job_runner` so I don't know if this is a particular concern and
users can't name a run `../leet_haxor/` to attack the way Copilot seems to
think.
`validate_key()` blocks slashes in `dag_id` and `validate_run_id()` blocks
them in `run_id`. `callback` id is a UUID that we generate. I think this is a
non-issue. Interestingly enough, Copilot is partially correct that we do allow
`..` in both, maybe we should tighten that up, but I think that is out of scope
here.
@vincbeck - can I get your thoughts on this when you get a sec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
