This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 2ab6f9490df Fix undefined variable in install_from_external_spec error
message (#63233)
2ab6f9490df is described below
commit 2ab6f9490dfbc205d1176d3d5dc1204d206f5397
Author: Xiaodong DENG <[email protected]>
AuthorDate: Mon Mar 9 17:57:08 2026 -0700
Fix undefined variable in install_from_external_spec error message (#63233)
The error message in install_from_external_spec() referenced
${INSTALLATION_METHOD} which does not exist — the correct variable
is ${AIRFLOW_INSTALLATION_METHOD}. With set -u active, hitting this
error path would crash with an "unbound variable" error instead of
printing the intended user-friendly message.
The typo was introduced in a1717a652b and carried forward into the
inlined copies in both Dockerfiles.
---
Dockerfile | 2 +-
Dockerfile.ci | 2 +-
scripts/docker/install_airflow_when_building_images.sh | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Dockerfile b/Dockerfile
index 251b589564d..aa3f1fba405 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1201,7 +1201,7 @@ function install_from_external_spec() {
installation_command_flags="apache-airflow[${AIRFLOW_EXTRAS}]${AIRFLOW_VERSION_SPECIFICATION}"
else
echo
- echo "${COLOR_RED}The '${INSTALLATION_METHOD}' installation method is
not supported${COLOR_RESET}"
+ echo "${COLOR_RED}The '${AIRFLOW_INSTALLATION_METHOD}' installation
method is not supported${COLOR_RESET}"
echo
echo "${COLOR_YELLOW}Supported methods are ('.',
'apache-airflow')${COLOR_RESET}"
echo
diff --git a/Dockerfile.ci b/Dockerfile.ci
index 5b0e6f7eaef..55229964f24 100644
--- a/Dockerfile.ci
+++ b/Dockerfile.ci
@@ -936,7 +936,7 @@ function install_from_external_spec() {
installation_command_flags="apache-airflow[${AIRFLOW_EXTRAS}]${AIRFLOW_VERSION_SPECIFICATION}"
else
echo
- echo "${COLOR_RED}The '${INSTALLATION_METHOD}' installation method is
not supported${COLOR_RESET}"
+ echo "${COLOR_RED}The '${AIRFLOW_INSTALLATION_METHOD}' installation
method is not supported${COLOR_RESET}"
echo
echo "${COLOR_YELLOW}Supported methods are ('.',
'apache-airflow')${COLOR_RESET}"
echo
diff --git a/scripts/docker/install_airflow_when_building_images.sh
b/scripts/docker/install_airflow_when_building_images.sh
index 5341a1cfc33..31b2c4062d4 100644
--- a/scripts/docker/install_airflow_when_building_images.sh
+++ b/scripts/docker/install_airflow_when_building_images.sh
@@ -148,7 +148,7 @@ function install_from_external_spec() {
installation_command_flags="apache-airflow[${AIRFLOW_EXTRAS}]${AIRFLOW_VERSION_SPECIFICATION}"
else
echo
- echo "${COLOR_RED}The '${INSTALLATION_METHOD}' installation method is
not supported${COLOR_RESET}"
+ echo "${COLOR_RED}The '${AIRFLOW_INSTALLATION_METHOD}' installation
method is not supported${COLOR_RESET}"
echo
echo "${COLOR_YELLOW}Supported methods are ('.',
'apache-airflow')${COLOR_RESET}"
echo
