YoannAbriel opened a new pull request, #63270:
URL: https://github.com/apache/airflow/pull/63270

   ## Problem
   
   When `render_template_as_native_obj=True` on a DAG, templates like `{{ ti 
}}` in `op_kwargs` resolve to live `TaskInstance` objects instead of strings. 
When `PythonVirtualenvOperator._write_args` tries to pickle these for the 
subprocess, it fails with a `PicklingError` from structlog internals (`Only 
BytesLoggers to sys.stdout and sys.stderr can be pickled`). The error gives no 
indication that the root cause is a non-serializable kwarg value.
   
   ## Root Cause
   
   `_write_args` calls `self.pickling_library.dumps(...)` on the full args dict 
without any pre-validation. When a value can't be pickled, the raw exception 
propagates — and since `TaskInstance` contains structlog loggers, the error 
message references structlog internals rather than the actual problem.
   
   ## Fix
   
   Wrap the `dumps` call in a try/except. On failure, iterate over `op_kwargs` 
to identify which specific keys hold non-serializable values, then raise an 
`AirflowException` naming the bad keys and suggesting alternatives (e.g. `{{ 
ti.task_id }}` instead of `{{ ti }}`).
   
   Added a unit test that verifies the improved error message when a 
non-serializable object is passed in `op_kwargs`.
   
   Closes: #61741
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to