Miretpl commented on code in PR #63187:
URL: https://github.com/apache/airflow/pull/63187#discussion_r2914434883
##########
helm-tests/tests/helm_tests/apiserver/test_hpa_apiserver.py:
##########
@@ -32,6 +32,31 @@ def test_hpa_disabled_by_default(self):
)
assert docs == []
+ def test_replicas_omitted_when_null(self):
+ """When apiServer.replicas is null the Deployment must not contain
spec.replicas."""
+ docs = render_chart(
+ values={
+ "airflowVersion": "3.0.2",
+ "apiServer": {
+ "replicas": None,
+ "hpa": {"enabled": True},
+ },
+ },
+ show_only=["templates/api-server/api-server-deployment.yaml"],
+ )
+ assert jmespath.search("spec.replicas", docs[0]) is None
+
+ def test_replicas_present_when_set(self):
+ """When apiServer.replicas is a number the Deployment must contain
spec.replicas."""
+ docs = render_chart(
+ values={
+ "airflowVersion": "3.0.2",
Review Comment:
```suggestion
```
##########
chart/values.schema.json:
##########
@@ -10649,82 +10652,13 @@
}
]
},
- "httpPort": {
Review Comment:
These changes are unrelated and should be reverted as they will break the
behaviour of GitSync change which was merged in the past days.
##########
helm-tests/tests/helm_tests/apiserver/test_hpa_apiserver.py:
##########
@@ -32,6 +32,31 @@ def test_hpa_disabled_by_default(self):
)
assert docs == []
+ def test_replicas_omitted_when_null(self):
+ """When apiServer.replicas is null the Deployment must not contain
spec.replicas."""
+ docs = render_chart(
+ values={
+ "airflowVersion": "3.0.2",
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
