potiuk commented on PR #60390: URL: https://github.com/apache/airflow/pull/60390#issuecomment-4035152066
@arjav1528 This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Gen-AI disclosure**: GitHub Copilot is listed as a co-author on three commits in this PR (commits updating db_cleanup.py and check_secrets_search_path_sync.py both carry 'Co-authored-by: Copilot'), yet the PR description contains no Gen-AI disclosure checkbox or statement. The contributing guidelines explicitly require: 'State in your PR description that you have used Gen-AI tools to assist in creating the PR.' - :x: **Coherent changes**: The file `scripts/ci/prek/check_secrets_search_path_sync.py` is modified (adding `and isinstance(elt.value, str)` to an AST traversal check) but is entirely unrelated to the stated purpose of the PR (fixing an FK constraint violation in `airflow db clean` for the `dag_version` table). This is a classic AI-generated-code signal: a tool introduced an unrelated change that the contributor did not remove before submitting. The contributing guidelines explicitly warn: 'Review your code to make sure it does not contain unrelated changes. Often Gen-AI tools might introduce changes that are not related to the problem you are trying to solve.' > **Note:** Your branch is **1214 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - Maintainers will then proceed with a normal review. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
