Sagargupta16 commented on PR #63109: URL: https://github.com/apache/airflow/pull/63109#issuecomment-4035557553
@potiuk thanks for the detailed feedback. Addressed all points: 1. **Rebased onto latest main** -- was 60 commits behind, now up to date. The static check failures (codespell in go-sdk and airflow-core) were from the base branch, not from this PR's Salesforce changes. 2. **Resolved review threads** -- both inline comments from @eladkal are addressed and resolved. The `_validate_inputs()` move from `__init__` to `execute()` is necessary so Jinja templates can render before validation runs. 3. **Provider tests** -- the single test failure was `test_s3_to_dynamodb_new_table_no_wait` in the Amazon provider, unrelated to Salesforce. Our tests all passed. CI should be clean now after the rebase. Marking as ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
