amoghrajesh commented on code in PR #62855:
URL: https://github.com/apache/airflow/pull/62855#discussion_r2916327975
##########
task-sdk/src/airflow/sdk/io/path.py:
##########
@@ -117,7 +121,7 @@ def __init__(
self._conn_id = storage_options.pop("conn_id", None)
super().__init__(*args, protocol=protocol, **storage_options)
- @classmethod_or_method # type: ignore[arg-type]
+ @_classmethod_or_method
Review Comment:
This seems pretty unconventional and hard to read for little benefit. If we
want to go down this route, I suggest we keep runtime import at top level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
