josh-fell commented on code in PR #61472:
URL: https://github.com/apache/airflow/pull/61472#discussion_r2919792657
##########
providers/dbt/cloud/src/airflow/providers/dbt/cloud/operators/dbt.py:
##########
@@ -212,16 +214,26 @@ def execute(self, context: Context):
raise DbtCloudJobRunException(f"Job run {self.run_id} has
failed or has been cancelled.")
return self.run_id
+
+ # Derive absolute deadlines for deferrable execution.
+ # execution_timeout is a hard task-level limit (cancels the job),
+ # while timeout only limits how long we wait for the job to finish.
+ # If both are set, the earliest deadline wins.
end_time = time.time() + self.timeout
+ execution_deadline = None
+ if self.execution_timeout:
Review Comment:
Let's explicitly call this out in the docstring since it seems important
enough to bubble-up to users. The curse of inheritance here hurts us with API
docs not including subclassed parameters.
##########
providers/dbt/cloud/src/airflow/providers/dbt/cloud/operators/dbt.py:
##########
@@ -70,7 +70,9 @@ class DbtCloudRunJobOperator(BaseOperator):
enabled but could be disabled to perform an asynchronous wait for a
long-running job run execution
using the ``DbtCloudJobRunSensor``.
:param timeout: Time in seconds to wait for a job run to reach a terminal
status for non-asynchronous
- waits. Used only if ``wait_for_termination`` is True. Defaults to 7
days.
+ waits. Used only if ``wait_for_termination`` is True.This limits how
long the operator waits for the
Review Comment:
```suggestion
waits. Used only if ``wait_for_termination`` is True. This limits
how long the operator waits for the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
