ferruzzi commented on PR #62918:
URL: https://github.com/apache/airflow/pull/62918#issuecomment-4040881583

   The change of location isn't necessarily bad, but I think it's somewhat 
irrelevant.  We can either do 
   
   ```
   if state == SUCCESS:
       prune
   if state == FAILURE:
       handle
       
   the existing if state in [SUCCESS, FAILURE]:   
     existing code
   ```
   
   or 
   
   ```
   the existing if state in [SUCCESS, FAILURE]:   
       if state == SUCCESS:
           prune
       if state == FAILURE:
           handle
      existing code
   ```
   
   I don't think the location itself matters, but maybe inside the existing "if 
terminal state" block is slightly easier to find/read.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to