Pyasma commented on code in PR #63113:
URL: https://github.com/apache/airflow/pull/63113#discussion_r2922283537
##########
airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts:
##########
@@ -91,15 +93,23 @@ export class ConnectionsPage extends BasePage {
this.successAlert = page.locator('[data-scope="toast"][data-part="root"]');
// Delete confirmation dialog
- this.confirmDeleteButton =
page.locator('button:has-text("Delete")').first();
+ this.confirmDeleteButton = page.getByRole("button", { name: "Delete"
}).first();
this.rowsPerPageSelect = page.locator("select");
// Sorting and filtering
this.tableHeader = page.locator('[role="columnheader"]').first();
- this.connectionIdHeader = page.locator("th:has-text('Connection
ID')").first();
- this.connectionTypeHeader = page.locator('th:has-text("Connection
Type")').first();
- this.hostHeader = page.locator('th:has-text("Host")').first();
+ this.connectionIdHeader = page
Review Comment:
I had getByRole here previously, but CI failed because it couldn't find the
exact accessible name for the header. I'd be happy to try
page.getByRole('columnheader', { name: /Connection ID/i }) (with a regex) if
you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
