potiuk commented on PR #61550: URL: https://github.com/apache/airflow/pull/61550#issuecomment-4054795382
@itayweb This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :warning: **code_quality**: In `_create_orm_dagrun` (dag.py), the resolved-dag callback copying only transfers `on_failure_callback` and `on_success_callback` but ignores other DAG-level callbacks (e.g., `on_retry_callback`, `sla_miss_callback`). This is fragile and may lead to silent behavior differences when triggering a specific bundle version. - :warning: **testing**: The new test `test_create_dagrun_uses_resolved_bundle_version_for_integrity` in test_dag.py verifies task instance creation from the resolved version but does not verify the callback-copying behavior introduced in the same change. The fragile callback logic should have dedicated test coverage. - :warning: **execution_api**: The Execution API `DagRun` model gains a new `bundle_version` field and a Cadwyn `AddBundleVersionField` migration is provided in `v2026_03_31`. The migration version re-uses an existing version date rather than introducing a new CalVer version — verify this is intentional and consistent with the project's Cadwyn versioning policy. > **Note:** Your branch is **46 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - Maintainers will then proceed with a normal review. Please address the issues above and push again. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
