SameerMesiah97 commented on code in PR #63533:
URL: https://github.com/apache/airflow/pull/63533#discussion_r2936766771
##########
providers/google/src/airflow/providers/google/cloud/triggers/cloud_storage_transfer_service.py:
##########
@@ -50,12 +52,14 @@ def __init__(
project_id: str = PROVIDE_PROJECT_ID,
poll_interval: int = 10,
gcp_conn_id: str = "google_cloud_default",
+ files: list[str] | None = None,
) -> None:
super().__init__()
self.project_id = project_id
self.gcp_conn_id = gcp_conn_id
self.job_names = job_names
self.poll_interval = poll_interval
+ self.files = files or []
Review Comment:
Nit: `self.files = files or []` collapses `None` and `[]`. My understanding
is that "files not provided" and "explicit empty list" are 2 distinct
scenarios. Perhaps you could do:
`self.files = files`
And then in the trigger event payload construction:
```
if self.files not None:
event_payload["files"] = self.files
```
That being said, I think it is fine as is so it's up to you if you want to
implement this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
