SameerMesiah97 commented on code in PR #62044:
URL: https://github.com/apache/airflow/pull/62044#discussion_r2937354136
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -252,9 +252,10 @@ def _parse_from_uri(self, uri: str):
else:
for key, value in query.items():
try:
- query[key] = json.loads(value)
- except (JSONDecodeError, TypeError):
- self.log.info("Failed parsing the json for key %s",
key)
+ if value:
Review Comment:
This code sits in the connection URI parsing path. By skipping the parse
attempt for empty values and downgrading log level from info to debug, failures
that were previously visible at info level will now become silent. I think it
would be better if the user were proactively informed of any malformed
connection URIs rather having to use debug mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
