YoannAbriel opened a new pull request, #63702:
URL: https://github.com/apache/airflow/pull/63702
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
closes: #63697
-->
`_are_premature_tis` uses a `finished_tis` list built at the start of the
scheduling loop. If the API concurrently marks a failed task as success
(clearing downstream tasks), the scheduler still sees the old states and
incorrectly marks further downstream tasks as `upstream_failed` — permanently,
since that's a terminal state.
Fix: don't pass the cached `finished_tis` to `DepContext`. Leaving it as
`None` makes `ensure_finished_tis()` re-query the DB, so trigger-rule
evaluation sees the latest committed states. `_are_premature_tis` only runs
when there are no schedulable/changed TIs, so the extra query has minimal
performance impact.
Added a test that simulates the race with two independent SQLAlchemy
sessions (scheduler vs API) and verifies `t1` is not stuck in `upstream_failed`
after `fail_task` is marked success and `t0` is cleared.
Closes: #63697
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4, claude-opus-4-6)
Generated-by: Claude Code (Opus 4, claude-opus-4-6) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
