xBis7 opened a new pull request, #63757:
URL: https://github.com/apache/airflow/pull/63757
This patch adds a script that checks the metrics in all provided files.
The script reads the metrics from the registry YAML file and checks if the
code metrics exist. If they do, then it validates that the metric type in the
code is the same as in the YAML.
In the code, there are a lot of dynamic metric names with variables in them.
Some of them belong to legacy metrics but not all of them.
For the dynamic metric names, if there is a partial match until the 1st
variable appears, then we consider the metric registered in the YAML. That's
the best scenario without having to account for all possible names after the
variable expansion.
It would be helpful to check if there are metrics in the YAML that don't
appear in the code but it's not feasible when running the script against
certain files and not every file in the project.
The next step after this PR, would be to remove the `DualStatsManager`
entirely from the codebase. When that happens, the only change in this patch
will be
```diff
- STATS_OBJECTS = {"Stats", "stats", "DualStatsManager"}
+ STATS_OBJECTS = {"Stats", "stats"}
```
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Claude Sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
