Vamsi-klu commented on PR #63610: URL: https://github.com/apache/airflow/pull/63610#issuecomment-4072591948
@jscheffl Thank you for the review. You're absolutely right that the AWS CLI cache directory is an AWS concern and shouldn't live in the generic CNCF provider. I've reworked the PR to move the fix entirely into the Amazon provider: - Removed all AWS-specific code from `KubernetesHook` (CNCF provider is untouched now) - Added `_ensure_eks_cache_dirs()` to `EksHook` in the Amazon provider - The function is called from `EksHook.generate_config_file()`, which is the method that sets up kubeconfig for EKS authentication - Tests have been moved from the CNCF test suite to the EKS hook test suite This way the CNCF Kubernetes provider stays completely cloud-neutral, and the race condition fix lives where the AWS auth concern actually belongs. (I believe you meant `EksHook` rather than `EcsHook` in your comment, since EKS is the Kubernetes service. I went with `EksHook` as the location.) All existing EKS hook tests (85) and Kubernetes hook tests (139) pass, along with the EksPodOperator tests (8). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
