Dev-iL opened a new pull request, #63788:
URL: https://github.com/apache/airflow/pull/63788
## Summary
- Change `if python_callable:` to `if python_callable is not None:` in
`task_decorator_factory()` to avoid triggering `__bool__` on callable objects.
- Convert the `task` attribute on the serialized DAG test proxy from a
class-level binding to a `@property`, preventing proxy leakage into the
decorator callable.
- Add test for callable objects with falsey `__bool__`.
- Remove `xfail` marker from
`test_infer_multiple_outputs_forward_annotation` (now passes).
## Details
`task_decorator_factory()` used `if python_callable:` which invokes
`__bool__` on the argument. This is incorrect — a callable that happens to be
falsey (e.g., `__bool__` returns `False`) would incorrectly take the "no
callable provided" path. The fix uses `is not None` for a proper identity check
and consolidates the error handling.
The test proxy in `dag_maker` bound `task = factory.dag.task` as a class
attribute, which caused proxy binding behavior to leak into the decorator when
accessed via `@dag.task`. Converting to a `@property` ensures the real `task`
decorator is returned without proxy interference.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related: #63520
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 4.6 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
