uranusjr commented on code in PR #63899:
URL: https://github.com/apache/airflow/pull/63899#discussion_r2955886422
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -134,8 +134,8 @@ class Connection(Base, LoggingMixin):
login: Mapped[str | None] = mapped_column(Text(), nullable=True)
_password: Mapped[str | None] = mapped_column("password", Text(),
nullable=True)
port: Mapped[int | None] = mapped_column(Integer(), nullable=True)
- is_encrypted: Mapped[bool] = mapped_column(Boolean, unique=False,
default=False)
- is_extra_encrypted: Mapped[bool] = mapped_column(Boolean, unique=False,
default=False)
+ is_encrypted: Mapped[bool | None] = mapped_column(Boolean, unique=False,
default=False)
Review Comment:
I think the problem is the field was nullable in 2.2.x (and earlier), and
changing this to non-nullable without a migration will cause problems if there
are nulls in the db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
