Lee-W commented on code in PR #63962:
URL: https://github.com/apache/airflow/pull/63962#discussion_r2964226551
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1912,18 +1912,28 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
active_runs=active_runs_of_dags.get(dag_model.dag_id),
)
continue
- if dag_model.next_dagrun is None and
dag_model.timetable_partitioned is False:
- self.log.error(
- "dag_model.next_dagrun is None; expected datetime",
- dag_id=dag_model.dag_id,
- )
- continue
- if dag_model.next_dagrun_create_after is None:
- self.log.error(
- "dag_model.next_dagrun_create_after is None; expected
datetime",
- dag_id=dag_model.dag_id,
- )
- continue
+ if dag_model.timetable_partitioned is False:
+ # non partition-aware DAGs
+ if dag_model.next_dagrun is None:
+ self.log.error(
+ "dag_model.next_dagrun is None; expected datetime",
+ dag_id=dag_model.dag_id,
+ )
+ continue
+ if dag_model.next_dagrun_create_after is None:
+ self.log.error(
+ "dag_model.next_dagrun_create_after is None; expected
datetime",
+ dag_id=dag_model.dag_id,
+ )
+ continue
+ else:
+ # partition-aware DAGs
Review Comment:
```suggestion
# partition-aware Dags
```
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1912,18 +1912,28 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
active_runs=active_runs_of_dags.get(dag_model.dag_id),
)
continue
- if dag_model.next_dagrun is None and
dag_model.timetable_partitioned is False:
- self.log.error(
- "dag_model.next_dagrun is None; expected datetime",
- dag_id=dag_model.dag_id,
- )
- continue
- if dag_model.next_dagrun_create_after is None:
- self.log.error(
- "dag_model.next_dagrun_create_after is None; expected
datetime",
- dag_id=dag_model.dag_id,
- )
- continue
+ if dag_model.timetable_partitioned is False:
+ # non partition-aware DAGs
Review Comment:
```suggestion
# non partition-aware Dags
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
