shivaam commented on code in PR #64010:
URL: https://github.com/apache/airflow/pull/64010#discussion_r2969394528
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -280,6 +329,15 @@ export const DagRuns = () => {
onStateChange={setTableURLState}
total={data?.total_entries}
/>
+ <ActionBar.Root closeOnInteractOutside={false}
open={Boolean(selectedRows.size)}>
+ <ActionBar.Content>
+ <ActionBar.SelectionTrigger>
+ {selectedRows.size} {translate("common:selected")}
Review Comment:
**ActionBar has no action buttons (Critical)**
The ActionBar currently shows only a selection count and close trigger — no
actual action buttons (Clear, Mark Success, Mark Failed, Delete). Compare with
`Variables.tsx` lines 239-241 which places `DeleteVariablesButton` between
`ActionBar.Separator` and `ActionBar.CloseTrigger`. Without action buttons, the
checkbox selection has no purpose.
Is this intentional as a first step with buttons coming in a follow-up PR?
If so, please mention that in the PR description.
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -265,7 +303,18 @@ export const DagRuns = () => {
},
);
- const columns = runColumns(translate, dagId);
+ const { allRowsSelected, clearSelections, handleRowSelect, handleSelectAll,
selectedRows } =
+ useRowSelection({
Review Comment:
**Selection key collision on global DAG Runs page (Medium)**
`dag_run_id` is unique only within a DAG — the DB has a
`UniqueConstraint("dag_id", "run_id")`, not on `run_id` alone. On the global
DAG Runs page (where `dagId` is `~`), two DAGs can share the same `dag_run_id`
(e.g., `scheduled__2024-01-01T00:00:00+00:00`), causing them to collide in the
selection Map.
The key must be composite:
```ts
getKey: (run) => `${run.dag_id}:${run.dag_run_id}`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
