eladkal commented on code in PR #63109:
URL: https://github.com/apache/airflow/pull/63109#discussion_r2971155925
##########
providers/salesforce/src/airflow/providers/salesforce/operators/bulk.py:
##########
@@ -48,6 +48,8 @@ class SalesforceBulkOperator(BaseOperator):
:param salesforce_conn_id: The :ref:`Salesforce Connection id
<howto/connection:SalesforceHook>`.
"""
+ template_fields: Sequence[str] = ("operation", "object_name", "payload",
"external_id_field")
Review Comment:
Please remove `operation` from this list.
The issue didn't explain use case for having this field templated.
Having `operation` as template field means to move `_validate_inputs` out of
init which defeats the propose of this validation.
##########
providers/salesforce/src/airflow/providers/salesforce/operators/bulk.py:
##########
@@ -70,7 +72,6 @@ def __init__(
self.batch_size = batch_size
self.use_serial = use_serial
self.salesforce_conn_id = salesforce_conn_id
- self._validate_inputs()
Review Comment:
given above comment please undo this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
