jscheffl commented on code in PR #62343:
URL: https://github.com/apache/airflow/pull/62343#discussion_r2971272801
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -257,6 +286,83 @@ def test_connection(test_body: ConnectionBody) ->
ConnectionTestResponse:
os.environ.pop(conn_env_var, None)
+@connections_router.post(
Review Comment:
LocalExecutor is "one" of the executors means it can serve as template for
other executors. But including K8s, Celery, Edge, AWS at least 4 additional
exist in the repo. So the logic would need to be added to each.
Technically - w/o looking into the code - I see 2 technical options:
- Implement it in the base class (BaseExecutor) and all individual
implementations can inherit
- Implement via a MixIn, then all Executors "just" need to use it... still
all executor classes need to be adjusted
Had only time to skim over the PR and have no answer, else I'd directly
propose an alternative. But I worry a bit that complexity grows with this
approach in each executor while I see in devlist additional features like
https://lists.apache.org/thread/o0z8v01v9qq26r6qmvx8zwbkmho1fnbg might need to
take the same route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
