hussein-awala commented on PR #64068: URL: https://github.com/apache/airflow/pull/64068#issuecomment-4106925146
A note on the API design: since xcoms is now on `TriggerEvent` (the base class), it's also available on events yielded by `BaseEventTrigger` subclasses (asset watchers). However, in `submit_event()`, the asset path only uses `event.payload` — any xcoms set on a watcher event would be silently ignored. This isn't a bug, but it could be confusing for users who set xcoms on a watcher trigger and expect them to land somewhere. It might be worth either: 1. Adding a warning log in `submit_event()` when `event.xcoms` is set but there are no deferred task instances to push them to, or 2. Documenting that xcoms only applies to task-deferred triggers, not asset watchers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
