plaes commented on code in PR #64135:
URL: https://github.com/apache/airflow/pull/64135#discussion_r2980309766


##########
chart/values.yaml:
##########
@@ -553,18 +552,24 @@ fernetKeySecretAnnotations: {}
 apiSecretKey: ~
 # Add custom annotations to the api secret
 apiSecretAnnotations: {}
+# Must contain an 'api-secret-key' key (suggested: random 32-char string).
+# Note: Values in K8s Secrets must be Base64 encoded.

Review Comment:
   This is somewhat confusing. It kinda tells me that I should base64 the value 
before adding it to secret...
   ```bash
   kubectl create --dry-run=client secret generic \
     admin --from-literal=api-secret-key=$(echo -n really-secret | base64) 
-oyaml
   ```
   And k8s re-encodes it in base64:
   ```yaml
   data:
     api-secret-key: Y21WaGJHeDVMWE5sWTNKbGRBPT0=
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to