eladkal commented on code in PR #64109:
URL: https://github.com/apache/airflow/pull/64109#discussion_r2980433995
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1913,14 +1913,6 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
)
for dag_model in dag_models:
- if dag_model.exceeds_max_non_backfill:
- self.log.warning(
- "Dag run cannot be created; max active runs exceeded.",
- dag_id=dag_model.dag_id,
- max_active_runs=dag_model.max_active_runs,
- active_runs=active_runs_of_dags.get(dag_model.dag_id),
- )
- continue
Review Comment:
is it right to remove this check?
Backfill has a special case as explained in the docs
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/backfill.html#concurrency-control
> You can set max_active_runs on a backfill and it will control how many Dag
runs in the backfill can run concurrently. Backfill max_active_runs is applied
independently the Dag max_active_runs setting.
The idea is to give the backfill run the power to limit concurrency even if
the scheduler can schedule it all at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
