eladkal opened a new pull request, #64153:
URL: https://github.com/apache/airflow/pull/64153
It looks like the Celery test was never executed due to return statement.
once removed the test started to run but discovered that it doesn't pass.
Hopefully I fixed all the issues and now it should pass
Here's a summary of all the fixes made to test_celery_executor.py:
1. Moved test_celery_integration, test_error_sending_task, and
test_retry_on_error_sending_task out of the dead-code helper function and into
TestCeleryExecutor as proper methods.
2. Inlined the dag setup directly in test_celery_integration instead of
using a separate helper (per your suggestion).
3. Derived TaskInstanceKeys from the actual dagrun task instances instead of
using hardcoded mismatched values.
4. Replaced ExecuteTask.make() (which requires ORM relationships) with
explicit ExecuteTask(...) construction with all required fields.
5. Fixed the sort destructuring order — "fail" sorts before "success"
alphabetically.
6. Set executor._sync_parallelism = 1 so task sending stays in the main
thread where mock patches are active.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [v] Yes (please specify the tool below)
Claude Opus 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
