huashi-st opened a new pull request, #64181:
URL: https://github.com/apache/airflow/pull/64181
Fix teardown tasks firing before all in-scope tasks complete.
Previously, teardown only checked direct upstream states, so it could run
while cleared or parallel in-scope tasks were still executing. adds
`_evaluate_teardown_scope()` to verify all tasks between setup and teardown
have reached a terminal state before proceeding.
closes: #29332
---
Test Dag
```python
import time
from datetime import datetime
from airflow.sdk import DAG, task
@task
def setup_resource():
print("Setting up resource")
@task
def task_fail():
raise ValueError("I'm designed to fail quickly")
@task
def task_slow():
print("Starting slow task...")
time.sleep(120)
print("Slow task done")
@task
def dummy():
print("Dummy task")
@task
def teardown_resource():
print("Tearing down resource")
with DAG(
dag_id="test_teardown_wait",
start_date=datetime(2024, 1, 1),
schedule=None,
catchup=False,
) as dag:
s = setup_resource()
t_fail = task_fail()
t_slow = task_slow()
d = dummy()
td = teardown_resource().as_teardown(setups=s)
s >> [t_fail, t_slow] >> d >> td
```
Before -
<img width="1890" height="694" alt="image"
src="https://github.com/user-attachments/assets/42ff4cb0-7aa4-45e7-833b-0e14b8c00562";
/>
After -
<img width="2180" height="1508" alt="image"
src="https://github.com/user-attachments/assets/59cbee3a-82f4-4e73-85c7-f62a99ed4fb3";
/>
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude (Cursor)
Generated-by: Claude (Cursor) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
