potiuk commented on code in PR #64124:
URL: https://github.com/apache/airflow/pull/64124#discussion_r2984978873
##########
scripts/ci/prek/ts_compile_lint_ui.py:
##########
@@ -50,8 +52,20 @@
all_ts_files.append("src/vite-env.d.ts")
print("All TypeScript files:", all_ts_files)
- run_command(["pnpm", "config", "set", "store-dir", ".pnpm-store"], cwd=dir)
- run_command(["pnpm", "install", "--frozen-lockfile",
"--config.confirmModulesPurge=false"], cwd=dir)
+ hash_file = AIRFLOW_ROOT_PATH / ".build" / "ui" / "pnpm-install-hash.txt"
Review Comment:
I think it's good as it is now, this way those scripts can be independent
from breeze (which is a good thing - one day we might decide it's finally good
time to separate breeze out (though it might never happen) - and relying on a
completely different distribution in monorepo adds unnecessary coupling. We
have now "scripts" distribution as well and I plan to do some more refactoring
so the scripts for hook that belongs to airflow-core will move to "scripts"
inside airflow-core and leave there - with scripts as dev dependency. And for
this it's just better that the scripts will remain "contained" within the
distribution it is in + those that are direct dev dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
