bbovenzi commented on code in PR #64211:
URL: https://github.com/apache/airflow/pull/64211#discussion_r2988809877
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -58,21 +60,30 @@ type TriggerDAGFormProps = {
const TriggerDAGForm = ({
dagDisplayName,
dagId,
+ error: submitErrorOverride,
hasSchedule,
isPartitioned,
isPaused,
+ isPending: isPendingOverride,
onClose,
+ onSubmitTrigger,
open,
prefillConfig,
}: TriggerDAGFormProps) => {
const { t: translate } = useTranslation(["common", "components"]);
const [errors, setErrors] = useState<{ conf?: string; date?: unknown }>({});
const [formError, setFormError] = useState(false);
const initialParamsDict = useDagParams(dagId, open);
- const { error: errorTrigger, isPending, triggerDagRun } = useTrigger({
dagId, onSuccessConfirm: onClose });
+ const {
+ error: triggerError,
+ isPending: isTriggerPending,
+ triggerDagRun,
+ } = useTrigger({ dagId, onSuccessConfirm: onClose });
const { conf, initialParamDict, setConf, setInitialParamDict } =
useParamStore();
const [unpause, setUnpause] = useState(true);
-
+ const submitError = submitErrorOverride ?? triggerError;
+ const submitPending = isPendingOverride ?? isTriggerPending;
+ const submitTrigger = onSubmitTrigger ?? triggerDagRun;
Review Comment:
Nit. we can drop "submit" from all of these. The function should also be a
verb like "onTrigger"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
