Pranaykarvi commented on PR #63878:
URL: https://github.com/apache/airflow/pull/63878#issuecomment-4133882894
Hi @SameerMesiah97, addressed all your review comments:
- Narrowed `except (PermissionError, OSError)` to `except PermissionError`
in both
`structlog.py` and `logging_config.py`
- Checked for the two additional `init_log_folder` paths you mentioned
(`task-sdk/src/airflow/sdk/_shared/logging/structlog.py` and
`airflow-core/src/airflow/_shared/logging/structlog.py`) — neither exists
in this
checkout, so only the active shared implementation was updated
- Added a regression test in
`shared/logging/tests/logging/test_structlog.py` that:
- patches `Path.mkdir` to raise `PermissionError`
- verifies no exception propagates
- verifies a warning is logged
- verifies execution continues normally
All changes pass `ruff format` and `ruff check --fix`. Please take another
look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
