jason810496 commented on code in PR #64220:
URL: https://github.com/apache/airflow/pull/64220#discussion_r2998985943
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_xcom.py:
##########
@@ -843,5 +843,5 @@ def test_patch_xcom_entry_with_slash_key(self, test_client,
session):
)
assert response.status_code == 200
assert response.json()["key"] == slash_key
- assert response.json()["value"] == json.dumps(new_value)
+ assert response.json()["value"] == new_value
check_last_log(session, dag_id=TEST_DAG_ID, event="update_xcom_entry",
logical_date=None)
Review Comment:
Wonder could we add the test scenario described in
https://github.com/apache/airflow/issues/59032 ?
For example, the existing XCom value type is `int` and after we patch the
XCom with different value, it should still be `int` in the API response.
To make sure the type of the XCom value is as expected after calling the
patch API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
