bbovenzi commented on code in PR #64267:
URL: https://github.com/apache/airflow/pull/64267#discussion_r3002959392
##########
airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/PluginImportErrors.tsx:
##########
@@ -38,42 +38,47 @@ export const PluginImportErrors = ({ iconOnly = false }: {
readonly iconOnly?: b
const importErrors = data?.import_errors ?? [];
if (isLoading) {
- return <Skeleton height="9" width="225px" />;
+ return iconOnly ? (
+ <Skeleton height="7" width="60px" />
+ ) : (
+ <Skeleton height="42px" width="175px" />
Review Comment:
Let's at least have a comment saying where these numbers are coming from.
And let's definitely fix this issue of mixing "7" with px values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
