sjyangkevin commented on code in PR #63454:
URL: https://github.com/apache/airflow/pull/63454#discussion_r3006529733
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -312,13 +323,16 @@ def sync(self) -> None:
try:
key = task.key
self.kube_scheduler.run_next(task)
- self.task_publish_retries.pop(key, None)
+ if not isinstance(key, str):
Review Comment:
Thanks for the feedback, I've resolved the first two comments but there are
some issues in my local checks preventing me to push.
For the use of `isinstance(key, str)`, there are some mypy issues when use
`isinstance(key, WorkloadKey)`. Will have a deeper look into this, to make sure
I am handling the different types of workloads properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
