potiuk commented on code in PR #63932: URL: https://github.com/apache/airflow/pull/63932#discussion_r3011546957
########## airflow-core/src/airflow/stats.py: ########## @@ -15,17 +15,16 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -"""Deprecated module - Stats moved to airflow.observability.stats but we have to retain compat.""" +"""Deprecated module - stats moved to airflow.observability.stats.""" from __future__ import annotations import warnings -from airflow.sdk.observability.stats import Stats as Stats Review Comment: Hmm - but they will get "Stats not exist" error I think - not the warning ? I do not think indeed we want to encourage using stats here, it's more of a potential compatibility issue if somene "still" uses "from airflow.stats import Stats" - in 3rd-party providers for example. It might be fine of course, but I think in this case we should rather raise explicit error (even if we want to tell people "deprecation period ended". but even in this case we might simply remove the whole file because `Stats` was the only thing that someone wanted to use from there. Or am I missing something ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
