wjddn279 commented on code in PR #64524:
URL: https://github.com/apache/airflow/pull/64524#discussion_r3014451814
##########
providers/pinecone/tests/system/pinecone/example_dag_pinecone.py:
##########
@@ -36,7 +36,7 @@
PineconeIngestOperator(
task_id="pinecone_vector_ingest",
index_name=index_name,
- input_vectors=[
+ input_vectors=[ # type: ignore[arg-type]
("id1", [1.0, 2.0, 3.0], {"key": "value"}),
Review Comment:
When I tested with mypy, passing the argument inline doesn't narrow the type
to`list[VectorTypedDict]` — it gets inferred as `list[object]`. We could
explicitly annotatethe variable
```python
vectors: list[VectorTypedDict] = [
{"id": "id1", "values": [1.0, 2.0, 3.0]},
{"id": "id2",},
]
```
But that would require additional imports. A type: ignore seems like the
cleaner option here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
