Lee-W commented on code in PR #63546:
URL: https://github.com/apache/airflow/pull/63546#discussion_r3014787189
##########
airflow/models/dag.py:
##########
@@ -4069,6 +4069,11 @@ def dags_needing_dagruns(cls, session: Session) ->
tuple[Query, dict[str, tuple[
This will return a resultset of rows that is row-level-locked with a
"SELECT ... FOR UPDATE" query,
you should ensure that any scheduling decisions are made in a single
transaction -- as soon as the
transaction is committed it will be unlocked.
+
+ For dataset-triggered scheduling, DAGs that have
``DatasetDagRunQueue`` rows but no matching
Review Comment:
```suggestion
For dataset-triggered scheduling, Dags that have
``DatasetDagRunQueue`` rows but no matching
```
##########
airflow/models/dag.py:
##########
@@ -4069,6 +4069,11 @@ def dags_needing_dagruns(cls, session: Session) ->
tuple[Query, dict[str, tuple[
This will return a resultset of rows that is row-level-locked with a
"SELECT ... FOR UPDATE" query,
you should ensure that any scheduling decisions are made in a single
transaction -- as soon as the
transaction is committed it will be unlocked.
+
+ For dataset-triggered scheduling, DAGs that have
``DatasetDagRunQueue`` rows but no matching
+ ``SerializedDagModel`` row are omitted from the returned
``dataset_triggered_dag_info`` until
+ serialization exists; queue rows are **not** deleted here so the
scheduler can re-evaluate on a
Review Comment:
```suggestion
serialization exists; DDRQs are **not** deleted here so the
scheduler can re-evaluate on a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
