Copilot commented on code in PR #64121:
URL: https://github.com/apache/airflow/pull/64121#discussion_r3025327920


##########
airflow-core/pyproject.toml:
##########
@@ -98,7 +98,7 @@ dependencies = [
     "uvicorn>=0.37.0",
     # Starlette 1.0.0 breaks the API server. Needs more investigation
     # https://github.com/apache/airflow/issues/64116

Review Comment:
   The comment says Starlette 1.0.0 breaks the API server / needs 
investigation, but the dependency is now set to `starlette>=1.0.0`. Please 
update or remove the comment (and/or replace it with a brief note that the 
issue is resolved by the TemplateResponse signature change) to avoid leaving 
misleading guidance for future maintainers.
   ```suggestion
       # Previous issues with Starlette 1.0.0 breaking the API server have been 
resolved
       # (see https://github.com/apache/airflow/issues/64116; fixed via 
TemplateResponse signature change).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to