Copilot commented on code in PR #64240:
URL: https://github.com/apache/airflow/pull/64240#discussion_r3025332470
##########
scripts/ci/prek/check_airflow_bug_report_template.py:
##########
@@ -30,7 +30,7 @@
import yaml
from common_prek_utils import AIRFLOW_ROOT_PATH, check_list_sorted, console
-BUG_REPORT_TEMPLATE = AIRFLOW_ROOT_PATH / ".github" / "ISSUE_TEMPLATE" /
"3-airflow_providers_bug_report.yml"
+BUG_REPORT_TEMPLATE = AIRFLOW_ROOT_PATH / ".github" / "ISSUE_TEMPLATE" /
"1-airflow_bug_report.yml"
DEPENDENCIES_JSON_FILE_PATH = AIRFLOW_ROOT_PATH / "generated" /
"provider_dependencies.json"
Review Comment:
This check script now points at `1-airflow_bug_report.yml`, but there are
still repository scripts that reference the deleted
`3-airflow_providers_bug_report.yml` (e.g.
`scripts/in_container/run_provider_yaml_files_check.py` opens that file). With
the providers template removed, those checks will fail at runtime unless they
are updated to read the consolidated template instead.
##########
.pre-commit-config.yaml:
##########
@@ -481,10 +481,10 @@ repos:
files: Dockerfile.*$
pass_filenames: true
require_serial: true
- - id: check-airflow-providers-bug-report-template
+ - id: check-airflow--bug-report-template
name: Sort airflow-bug-report provider list
language: python
- files: ^\.github/ISSUE_TEMPLATE/3-airflow_providers_bug_report\.yml$
+ files: ^\.github/ISSUE_TEMPLATE/1-airflow_bug_report\.yml$
require_serial: true
entry: ./scripts/ci/prek/check_airflow_bug_report_template.py
Review Comment:
The pre-commit hook id was changed to `check-airflow--bug-report-template`
(double hyphen). This looks like a typo and also breaks existing references to
the old id (`check-airflow-providers-bug-report-template`) used elsewhere (e.g.
Breeze selective check skipping / tests), so those callers will no longer be
able to target/skip this hook. Consider keeping the original id or updating all
internal references to the new id (and fix the double hyphen).
##########
.github/ISSUE_TEMPLATE/1-airflow_bug_report.yml:
##########
@@ -96,13 +103,176 @@ body:
- "Amazon (AWS) MWAA"
- "Microsoft ADF Managed Airflow"
- "Other"
+ - type: dropdown
+ attributes:
+ label: Apache Airflow Provider(s)
+ description: >
+ Provider(s) that the issue report is about (you can choose more than
one).Select "None" if
+ the issue category isn't "Providers".
+ multiple: true
+ options:
+ - airbyte
+ - alibaba
+ - amazon
+ - apache-beam
+ - apache-cassandra
+ - apache-drill
+ - apache-druid
+ - apache-flink
+ - apache-hdfs
+ - apache-hive
+ - apache-iceberg
+ - apache-impala
+ - apache-kafka
+ - apache-kylin
+ - apache-livy
+ - apache-pig
+ - apache-pinot
+ - apache-spark
+ - apache-tinkerpop
+ - apprise
+ - arangodb
+ - asana
+ - atlassian-jira
+ - celery
+ - cloudant
+ - cncf-kubernetes
+ - cohere
+ - common-ai
+ - common-compat
+ - common-io
+ - common-messaging
+ - common-sql
+ - databricks
+ - datadog
+ - dbt-cloud
+ - dingding
+ - discord
+ - docker
+ - edge3
+ - elasticsearch
+ - exasol
+ - fab
+ - facebook
+ - ftp
+ - git
+ - github
+ - google
+ - grpc
+ - hashicorp
+ - http
+ - imap
+ - influxdb
+ - informatica
+ - jdbc
+ - jenkins
+ - keycloak
+ - microsoft-azure
+ - microsoft-mssql
+ - microsoft-psrp
+ - microsoft-winrm
+ - mongo
+ - mysql
+ - neo4j
+ - odbc
+ - openai
+ - openfaas
+ - openlineage
+ - opensearch
+ - opsgenie
+ - oracle
+ - pagerduty
+ - papermill
+ - pgvector
+ - pinecone
+ - postgres
+ - presto
+ - qdrant
+ - redis
+ - salesforce
+ - samba
+ - segment
+ - sendgrid
+ - sftp
+ - singularity
+ - slack
+ - smtp
+ - snowflake
+ - sqlite
+ - ssh
+ - standard
+ - tableau
+ - telegram
+ - teradata
+ - trino
+ - vertica
+ - weaviate
+ - yandex
+ - ydb
+ - zendesk
+ - type: textarea
+ attributes:
+ label: Versions of Apache Airflow Providers
+ description: What Apache Airflow Providers versions are you using?
+ placeholder: You can use `pip freeze | grep apache-airflow-providers`
(you can leave only relevant ones)
+ - type: dropdown
+ attributes:
+ label: Official Helm Chart version
+ description: >
+ What Apache Airflow Helm Chart version are you using?if the issue
category
+ isn't "Helm chart" select "Not Applicable".
Review Comment:
Minor formatting/grammar issues in the Helm chart version field description
reduce readability (missing space after `using?`, and `if` should start a new
sentence or be separated). Please adjust the text to read naturally (e.g. add
spaces/punctuation).
```suggestion
What Apache Airflow Helm Chart version are you using? If the issue
category
isn't "Helm chart", select "Not Applicable".
```
##########
.github/ISSUE_TEMPLATE/1-airflow_bug_report.yml:
##########
@@ -96,13 +103,176 @@ body:
- "Amazon (AWS) MWAA"
- "Microsoft ADF Managed Airflow"
- "Other"
+ - type: dropdown
+ attributes:
+ label: Apache Airflow Provider(s)
+ description: >
+ Provider(s) that the issue report is about (you can choose more than
one).Select "None" if
+ the issue category isn't "Providers".
Review Comment:
The provider dropdown description tells users to select "None" when the
issue category isn't "Providers", but there is no "None"/"Not applicable"
option in the list. Either add an explicit non-provider option (and adjust the
sorting/validation script to allow it) or remove this instruction so users
aren’t asked to pick a value that can’t be selected.
```suggestion
Provider(s) that the issue report is about (you can choose more than
one). If the issue
category isn't "Providers", you can leave this field empty.
```
##########
.github/ISSUE_TEMPLATE/1-airflow_bug_report.yml:
##########
@@ -96,13 +103,176 @@ body:
- "Amazon (AWS) MWAA"
- "Microsoft ADF Managed Airflow"
- "Other"
+ - type: dropdown
+ attributes:
+ label: Apache Airflow Provider(s)
+ description: >
+ Provider(s) that the issue report is about (you can choose more than
one).Select "None" if
+ the issue category isn't "Providers".
+ multiple: true
+ options:
+ - airbyte
+ - alibaba
+ - amazon
+ - apache-beam
+ - apache-cassandra
+ - apache-drill
+ - apache-druid
+ - apache-flink
+ - apache-hdfs
+ - apache-hive
+ - apache-iceberg
+ - apache-impala
+ - apache-kafka
+ - apache-kylin
+ - apache-livy
+ - apache-pig
+ - apache-pinot
+ - apache-spark
+ - apache-tinkerpop
+ - apprise
+ - arangodb
+ - asana
+ - atlassian-jira
+ - celery
+ - cloudant
+ - cncf-kubernetes
+ - cohere
+ - common-ai
+ - common-compat
+ - common-io
+ - common-messaging
+ - common-sql
+ - databricks
+ - datadog
+ - dbt-cloud
+ - dingding
+ - discord
+ - docker
+ - edge3
+ - elasticsearch
+ - exasol
+ - fab
+ - facebook
+ - ftp
+ - git
+ - github
+ - google
+ - grpc
+ - hashicorp
+ - http
+ - imap
+ - influxdb
+ - informatica
+ - jdbc
+ - jenkins
+ - keycloak
+ - microsoft-azure
+ - microsoft-mssql
+ - microsoft-psrp
+ - microsoft-winrm
+ - mongo
+ - mysql
+ - neo4j
+ - odbc
+ - openai
+ - openfaas
+ - openlineage
+ - opensearch
+ - opsgenie
+ - oracle
+ - pagerduty
+ - papermill
+ - pgvector
+ - pinecone
+ - postgres
+ - presto
+ - qdrant
+ - redis
+ - salesforce
+ - samba
+ - segment
+ - sendgrid
+ - sftp
+ - singularity
+ - slack
+ - smtp
+ - snowflake
+ - sqlite
+ - ssh
+ - standard
+ - tableau
+ - telegram
+ - teradata
+ - trino
+ - vertica
+ - weaviate
+ - yandex
+ - ydb
+ - zendesk
+ - type: textarea
+ attributes:
+ label: Versions of Apache Airflow Providers
+ description: What Apache Airflow Providers versions are you using?
+ placeholder: You can use `pip freeze | grep apache-airflow-providers`
(you can leave only relevant ones)
+ - type: dropdown
+ attributes:
+ label: Official Helm Chart version
+ description: >
+ What Apache Airflow Helm Chart version are you using?if the issue
category
+ isn't "Helm chart" select "Not Applicable".
+ multiple: false
+ options:
+ - "Not Applicable"
+ - "1.20.0 (latest released)"
+ - "1.19.0"
+ - "1.18.0"
+ - "1.17.0"
+ - "1.16.0"
+ - "1.15.0"
+ - "1.14.0"
+ - "1.13.1"
+ - "1.13.0"
+ - "1.12.0"
+ - "1.11.0"
+ - "1.10.0"
+ - "1.9.0"
+ - "1.8.0"
+ - "1.7.0"
+ - "1.6.0"
+ - "1.5.0"
+ - "1.4.0"
+ - "1.3.0"
+ - "1.2.0"
+ - "1.1.0"
+ - "1.0.0"
+ - "main (development)"
+ default: 0
+ validations:
+ required: true
+ - type: input
+ attributes:
+ label: Kubernetes Version
+ description: Which Kubernetes Version do you use? Enter "Not Applicable"
if the issue type isn't
+ "Helm chart".
+ - type: textarea
+ attributes:
+ label: Helm Chart configuration
+ description: Additional description of your Helm Chart configuration.
Enter "Not Applicable" if the
+ issue type isn't "Helm chart".
+ placeholder: >
+ Enter any relevant details of your Helm Chart configuration. Maybe you
can
+ paste your `values.yaml` or important parts of it here? Make sure to
surround the code
+ you paste with ``` ```.
- type: textarea
attributes:
- label: Deployment details
- description: Additional description of your deployment.
+ label: Docker Image customizations
+ description: What are the specific modification you've made in your
image?
placeholder: >
- Enter any relevant details of your deployment. Especially version of
your tools,
- software (docker-compose, helm, k8s, etc.), any customisation and
configuration you added.
+ Enter "Not Applicable" if the issue type isn't "Helm chart".
Review Comment:
The "Docker Image customizations" prompt/placeholder currently says to enter
"Not Applicable" when the issue type isn't "Helm chart", but Docker image
customization is relevant for many non-Helm deployments too. Either
scope/rename this field to Helm-chart-specific (to match the guidance) or
update the guidance so it aligns with the field’s purpose.
```suggestion
If you have not customized your Docker image, you can enter "Not
Applicable".
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
