deepujain commented on PR #64016: URL: https://github.com/apache/airflow/pull/64016#issuecomment-4174155024
Picked up the follow-up review items on this branch. I moved `mask_secret` to module scope in the SDK config parser, and rewrote the regression so it actually goes through `supervise()` and verifies the config-derived masks are back in place before `ActivitySubprocess.start()` runs. Local validation: targeted `test_supervise_remasks_config_secrets_after_reset` passed, and `ruff check` plus `ruff format --check` passed on the touched task-sdk files. I also tried the full `test_supervisor.py` file locally, but one unrelated remote-logging test still fails in this workspace because `airflow.providers.amazon` is not installed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
