pierrejeambrun commented on code in PR #64552:
URL: https://github.com/apache/airflow/pull/64552#discussion_r3028505465
##########
airflow-core/src/airflow/ui/src/theme.ts:
##########
@@ -406,16 +406,20 @@ const defaultAirflowTheme = {
export const createTheme = (userTheme?: Theme) => {
const defaultAirflowConfig = defineConfig({ theme: defaultAirflowTheme });
- const userConfig = defineConfig(
- userTheme
- ? {
- theme: { tokens: userTheme.tokens },
+ const userConfig = userTheme
+ ? defineConfig({
+ ...(userTheme.tokens !== undefined && {
+ theme: { tokens: userTheme.tokens as Record<string, unknown> },
+ }),
+ ...(userTheme.globalCss !== undefined && {
globalCss: userTheme.globalCss as Record<string, SystemStyleObject>,
- }
- : {},
- );
+ }),
Review Comment:
It's ok for now. It should get extended further, icons cannot go there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
