shivaam commented on code in PR #64735:
URL: https://github.com/apache/airflow/pull/64735#discussion_r3036302129
##########
airflow-core/src/airflow/ui/src/queries/useBulkDeleteConnections.tsx:
##########
@@ -54,7 +54,9 @@ export const useBulkDeleteConnections = ({ clearSelections,
onSuccessConfirm }:
keys: success.join(", "),
resourceName: translate("admin:connections.connection_other"),
}),
- title: translate("toaster.bulkDelete.success.title"),
+ title: translate("toaster.bulkDelete.success.title", {
+ resourceName: translate("admin:connections.connection_other"),
Review Comment:
nit: consider `translate("admin:connections.connection", { count:
success.length })` here (and for the description's `resourceName` above) to
match the count-driven plural pattern used by `DataTable` elsewhere in the UI.
It would make the toast grammatically correct for n=1 and for languages with
richer plural forms. Since the function is available, I think we should use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
