antonio-mello-ai commented on PR #63467: URL: https://github.com/apache/airflow/pull/63467#issuecomment-4191704030
@pierrejeambrun Thanks for the review! **1. Duplicated code with `getParsedLogs`** — this is actually already addressed. The original `getParsedLogs` (inline in `Logs.tsx`) was extracted into `getTextLines()` in `utils.ts` and the original removed. Both the search matching and `getLogString` (for download) now use `getTextLines`, so there's a single source for the parse+render pipeline. **2. Confusing `currentMatchIndex` naming** — agreed, fixed in a526dd4. Renamed the state variable to `activeSearchIndex` (the position within the search results array) to disambiguate from `currentMatchLineIndex` (the actual log line index). The prop name `currentMatchIndex` passed to `LogSearchInput` stays the same since it's unambiguous in that component's context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
