jscheffl commented on code in PR #64777:
URL: https://github.com/apache/airflow/pull/64777#discussion_r3040790894
##########
dev/breeze/src/airflow_breeze/commands/ci_commands.py:
##########
@@ -798,20 +790,42 @@ def upgrade(
"upgrade-important-versions",
"prek --all-files --show-diff-on-failure --color always --verbose
--stage manual upgrade-important-versions",
),
+ ]
+
+ # Define upgrade commands to run after building the CI image (they run
inside the image
+ # and need an up-to-date environment).
+ post_image_commands: list[tuple[str, str]] = [
(
"update-uv-lock",
"prek --all-files --show-diff-on-failure --color always --verbose
update-uv-lock --stage manual",
),
]
+
step_enabled = {
"autoupdate": autoupdate,
"update-chart-dependencies": update_chart_dependencies,
"upgrade-important-versions": upgrade_important_versions,
"update-uv-lock": update_uv_lock,
}
- # Execute enabled upgrade commands with the environment containing GitHub
token
- for step_name, command in upgrade_commands:
+ # Execute pre-image upgrade commands (may update Dockerfiles)
+ for step_name, command in pre_image_commands:
+ if step_enabled[step_name]:
+ run_command(command.split(), check=False, env=command_env)
+ else:
+ console_print(f"[info]Skipping {step_name} (disabled).[/]")
+
+ # Build the CI image for Python 3.10 after Dockerfiles have been updated
so that
Review Comment:
We decided to always use lowest version in CI to ensure that we are really
compatible to the oldest supported Python version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
