anishgirianish commented on PR #63491:
URL: https://github.com/apache/airflow/pull/63491#issuecomment-4195881132
> You got asked to fix the issues - before marking it ready . Don't do it
next time.
Hi @potiuk,
Thank you so much for taking the time to review and for all the work you do
maintaining the triage process. I truly appreciate it.
I sincerely apologize for marking the PR as ready without resolving the
merge conflicts first. That was my mistake, and I completely understand why it
was flagged. I'll be more careful going forward and will make sure everything
is in order before marking ready again. Thank you for pointing that out it
helps me learn the process better.
I had a question about the provider test failures and would really
appreciate your guidance. The two failing tests (test_gauge_executor_metrics in
both celery and kubernetes executor tests) are related to the trigger_tasks →
trigger_workloads rename that this PR introduces for 3.3. The tests already
have a version guard using AIRFLOW_V_3_3_PLUS to handle backward compatibility,
but since main is currently on 3.2, the flag evaluates to False and the tests
try to mock the old method name, which no longer exists on this branch.
Would the correct approach be to keep this PR in draft state until main
moves to 3.3, and then rebase and mark it ready at that point? I'd love to know
what you'd recommend so I can follow the right process.
Thank you so much for your patience and guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
