Miretpl commented on code in PR #64032:
URL: https://github.com/apache/airflow/pull/64032#discussion_r3046150004
##########
chart/templates/_helpers.yaml:
##########
@@ -1138,7 +1138,7 @@ Usage:
{{- if gt (len $nested) 0 -}}
{{- $_ := set $newValues $key $nested -}}
{{- end -}}
- {{- else if not (eq $val nil) -}}
+ {{- else if $val -}}
Review Comment:
The logic itself of how sets are overwriting the `workers.celery` values
will probably stay as-is, as the native Helm functions are not sufficient in
terms of how they work, but the whole simplification is something that will
surely be done. Some of the logic from the merge function will probably be
removed after Helm Chart 2.0 (and/or will be rewritten), as a lot of things
will be simplified with the removal of all deprecations, but, at least for now,
I would not say that it will make the nil removal function redundant. Maybe it
will be merged with the merge function; we will see.
P.S. Most of the values have a default value, but some of them are not set,
like e.g. `workers.podManagementPolicy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
