nailo2c commented on code in PR #64650:
URL: https://github.com/apache/airflow/pull/64650#discussion_r3066863222
##########
go-sdk/pkg/worker/runner_test.go:
##########
@@ -215,8 +213,9 @@ func (s *WorkerSuite) TestTaskHeartbeatsWhileRunning() {
// Since we heartbeat every 100ms and run for 1 second, we should
expect 10 heartbeat calls. But allow +/-
// 1 due to timing imprecision
+ count := callCount.Load()
s.Assert().
- True(callCount <= 11 && callCount >= 9, fmt.Sprintf("Call count
of %d was not within the margin of error of 10+/-1", callCount))
+ True(count <= 11 && count >= 9, fmt.Sprintf("Call count of %d
was not within the margin of error of 10+/-1", count))
Review Comment:
I think this should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
