rjgoyln opened a new pull request, #65230:
URL: https://github.com/apache/airflow/pull/65230
### Summary
This PR fixes a downgrade regression introduced in the 3.2.0 callback table
migration.
After downgrading to 3.1.x, callback_request.id could lose its
auto-increment/default behavior, which led to NotNullViolation errors and
scheduler instability.
The fix restores database-specific auto-increment defaults and adds
regression coverage to prevent recurrence.
### Changes
- Updated migration 0093 downgrade logic to reliably restore
callback_request.id auto-increment behavior after table restructuring.
- Added PostgreSQL-specific sequence recovery: create/own sequence, set
value safely for empty and non-empty tables, and re-attach nextval as column
default.
- Added MySQL-specific AUTO_INCREMENT recovery using MAX(id) + 1.
- Added a PostgreSQL regression test that runs the downgrade path and
verifies:
- id has a valid default expression
- inserts without an explicit id succeed.
* closes: #65000
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
