nathadfield commented on PR #63884: URL: https://github.com/apache/airflow/pull/63884#issuecomment-4247384629
> PR mentions the `backfill.py` endpoint but there is no update there, we need to also use the resolver `resolve_run_on_latest_version` (probably move that to a shared place, not sure why it's in the dagrun service of the API layer) > > Also this is not taken into account in the CLI. (backfill commands) Thanks @pierrejeambrun , good points. A few thoughts on how to address them: **Resolver location:** I agree it doesn't belong in the `dag_run` service. I'll move `resolve_run_on_latest_version` to `services/public/common.py` so it's shared across `dag_run`, `task_instances`, and `backfill` endpoints. **Backfill endpoint:** I'll change `BackfillPostBody.run_on_latest_version` from `bool = True` to `bool | None = None` and use the resolver, same as the clear endpoints. This means backfills will also respect the DAG-level and global config hierarchy. The current `True` default was the pre-existing behavior, so this is a behavioral change for backfills. Are you OK with that, or should backfills default to `True` when no config is set (i.e., use `True` as the fallback instead of `False`)? **CLI backfill command:** The CLI currently passes `--run-on-latest-version` (defaults to True) directly to `_create_backfill`. I can have it resolve through the same hierarchy when the flag isn't explicitly provided. The question is the same: should the backfill fallback be True (current behavior) or False (matching the clear endpoints)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
