necmo commented on code in PR #65222:
URL: https://github.com/apache/airflow/pull/65222#discussion_r3083653138


##########
airflow-core/src/airflow/serialization/definitions/notset.py:
##########
@@ -31,6 +31,12 @@
 class ArgNotSet:
     """Sentinel type for annotations, useful when None is not viable."""
 
+    def __repr__(self) -> str:
+        return "NOTSET"
+

Review Comment:
   Addressed — replaced `__repr__`/`__str__` with `serialize()` method so 
`SetDuringExecution` inheritance is unaffected.



##########
airflow-core/src/airflow/serialization/definitions/notset.py:
##########
@@ -31,6 +31,12 @@
 class ArgNotSet:
     """Sentinel type for annotations, useful when None is not viable."""
 

Review Comment:
   Addressed — added `serialize()` to `ArgNotSet` so `serialize_template_field` 
uses it instead of the `str()` fallback path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to