seruman opened a new pull request, #65310:
URL: https://github.com/apache/airflow/pull/65310
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
When a DAG explicitly sets `max_active_runs=16` and `airflow.cfg` has
`max_active_runs_per_dag = 1`, the `dag` table ends up with `1`. Setting it to
`17` or any other value that isn't `16` works fine.
The serialisation optimisation from #55849 strips DAG fields that match
their `schema.json` default.
This works for static defaults like `catchup=False`, but `max_active_runs`,
`max_active_tasks`, and `max_consecutive_failed_dag_runs` get their defaults
from `airflow.cfg` at parse time, not from the schema.
When the user's explicit value happens to equal the schema default (16), it
gets stripped, `LazyDeserializedDAG` returns `None`, and `collection.py` falls
back to whatever `airflow.cfg` says.
The fix skips the schema-default exclusion for these three config-driven
fields so they always survive serialisation.
After deploying this, the first parse cycle will produce a slightly
different serialised payload for every DAG (three extra int fields), which
means a one-time `dag_hash` change and a new `DagVersion` for DAGs that have
running task instances.
closes: #65307
related: #57604
related: #56646
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes
Generated-by: pi (Claude Opus 4.6) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
